#429: Added a peek function to the factory that decides whether .xml files are ReqM2 files #469
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…files are ReqM2 files
kaklakariada
requested changes
Sep 9, 2025
...rc/main/java/org/itsallcode/openfasttrace/importer/specobject/SpecobjectImporterFactory.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/itsallcode/openfasttrace/importer/specobject/SpecobjectImporterFactory.java
Outdated
Show resolved
Hide resolved
github-project-automation
bot
moved this from 📫 Backlog
to 🔨 In Progress
in OpenFastTrace
Co-authored-by: Christoph Pirkl <4711730+kaklakariada@users.noreply.github.com>
- Extracted method for header peeking - Implemented `ImporterFactory` directly - Fixed release date
… since the certificate chain does not validate properly on GitHub actions.
|
kaklakariada
approved these changes
Sep 14, 2025
redcatbear
deleted the
bug/429_importing-xml-files-with-doctype-fails
branch
github-project-automation
bot
moved this from 🔨 In Progress
to ✅ Closed
in OpenFastTrace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR adds a peek function that looks into the XML file. If it contains
<specdocumentin the firt 4 KiB, then the it is considered a ReqM2 file. Otherwise it is ignored as a generic XML file.Closes #429.